Avoid userland re-entrance after a read in Float16Array#spliced

tc39/proposal-change-array-by-copy#89
petamoriken · Jun 26, 2022 · edf3bc3 · edf3bc3
1 parent e458f3f
commit edf3bc3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Float16Array.mjs b/src/Float16Array.mjs
@@ -1044,6 +1044,11 @@ export class Float16Array {
     }
 
     const insertCount = items.length;
+    const converedItems = [];
+    for (let i = 0; i < insertCount; ++i) {
+      converedItems[i] = ToNumber(items[i]);
+    }
+
     let actualDeleteCount;
     switch (arguments.length) {
       case 0:
@@ -1081,7 +1086,7 @@ export class Float16Array {
     }
 
     for (let i = 0; i < insertCount; ++i) {
-      array[k] = roundToFloat16Bits(items[i]);
+      array[k] = roundToFloat16Bits(converedItems[i]);
       ++k;
     }