Update hfround to throw TypeError when value is bigint

petamoriken · Sep 14, 2021 · 3096f45 · 3096f45
1 parent 8257ac0
commit 3096f45
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/hfround.mjs b/src/hfround.mjs
@@ -6,6 +6,10 @@ import { convertToNumber, roundToFloat16Bits } from "./helper/converter.mjs";
  * @returns {number}
  */
 export function hfround(num) {
+  if (typeof num === "bigint") {
+    throw TypeError("Cannot convert a BigInt value to a number");
+  }
+
   num = Number(num);
 
   // for optimization

diff --git a/test/hfround.js b/test/hfround.js
@@ -1,4 +1,4 @@
-/* eslint-env mocha */
+/* eslint-env mocha, es2020 */
 /* global assert hfround */
 
 describe("hfround()", () => {
@@ -64,4 +64,13 @@ describe("hfround()", () => {
   it("return 1.3369140625 when value is 1.337", () => {
     assert( hfround(1.337) === 1.3369140625 );
   });
+
+  it("throw TypeError when value is bigint", function () {
+    // Safari 13 doesn't have BigInt
+    if (typeof BigInt === "undefined") {
+      this.skip();
+    }
+
+    assert.throws(() => { hfround(BigInt(0)); }, TypeError);
+  });
 });