Fix learning method matches for the detect events #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 68.23% 68.17% -0.06%
==========================================
Files 95 95
Lines 20350 20565 +215
==========================================
+ Hits 13885 14021 +136
- Misses 6465 6544 +79 ☔ View full report in Codecov by Sentry. |
kimhanbeom
force-pushed
the
david/issue-322
branch
from
fc3ecc6 to
407fb44
Compare
syncpark
approved these changes
Feb 26, 2025
The previous implementation of learning method match used the `EventCategory`, but now all detected events have been modified to return `LearningMethod` (via the new `learning_method` method added to `Match` trait), so learning method match is performed using this value. Close: petabi#322
kimhanbeom
force-pushed
the
david/issue-322
branch
from
407fb44 to
8de8ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of learning method match used the
EventCategory, but now all detected events have been modified to returnLearningMethod(via the newlearning_methodmethod added toMatchtrait), so learning method match is performed using this value.Close: #322