Fix should help examples #1647
Merged
Fix should help examples #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asears
commented
Sep 24, 2020
|
Very nice PR mr. @asears. I personally really appreciate these kind of changes for their educational value. I've added one remark relating to the multi line code examples, they should be fenced or they will not render properly on the pester.dev website. https://docusaurus-powershell.netlify.app/docs/faq/multi-line-examples |
nohwnd
reviewed
Sep 26, 2020
Co-authored-by: Jakub Jareš <[email protected]>
Co-authored-by: Jakub Jareš <[email protected]>
Co-authored-by: Jakub Jareš <[email protected]>
Co-authored-by: Jakub Jareš <[email protected]>
Fence code examples, split link examples
Add definition
Updates to test parameters documentation
nohwnd
reviewed
Oct 1, 2020
Co-authored-by: Jakub Jareš <[email protected]>
clarify local runs of test.ps1
|
LGTM, @asears are you done with all your changes? |
|
Yes will open another PR if I have further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: asears [email protected]
1. General summary of the pull request
Improves #1634