Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ast parsing #1258

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Ast parsing #1258

merged 3 commits into from
Mar 8, 2019

Conversation

renehernandez
Copy link
Contributor

@renehernandez renehernandez commented Mar 6, 2019 •
edited
Loading

1. General summary of the pull request

Fix #1256
Fix #1257

@renehernandez
Copy link
Contributor Author

@nohwnd The failing test is due to a timing issue. Any advice there?

Reverse variables array before replacement
21d3f74 
Means that replacement will go from right to left and avoid introducing
changes in text size and the offsets calculations

Add break after a succesful replacement for a variable
@nohwnd nohwnd merged commit 569f2ec into pester:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null check in pester 4.7 fails Last character in parameter filter script blocks getting stripped
2 participants
@renehernandez @nohwnd