Fixed detection of empty tests #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue #833
|
Thanks for the PR, but you have to support PowerShell v2, please review the failure log on our build server to learn more about why it fails on PowerShell v2. (Imho it's the Ast, and you should rather depend on regex - at least for powershell 2). |
it-praktyk
reviewed
Dec 19, 2017
Functions/It.ps1
Outdated
| @@ -158,8 +158,12 @@ function ItImpl | |||
|
|
|||
| #mark empty Its as Pending | |||
| #[String]::IsNullOrWhitespace is not available in .NET version used with PowerShell 2 | |||
There was a problem hiding this comment.
@Remco-74, exactly in this line is an answer why the sollution proposed by you doesn't work with PowerShell 2.
Can you change your code to use the old detection method when it's run with PowerShell 2.0 and the new one for the newer version of PowerShell?
it-praktyk
suggested changes
Dec 19, 2017
it-praktyk
approved these changes
Jan 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #833