Parameterized Tests don't get marked as Inconclusive when empty

[RemcoKapinga]

When using an empty parameterized test, the test does not get marked as 'Inconclusive'. It does get marked as 'Passed'.

Describe 'Defect: Parameterized Tests do not get marked as Inconclusive when empty.' {

    BeforeAll {
        $testCases = @{ Name = 'a' }
    }

    It 'will mark an empty test method as Inconclusive' {

    }

    It 'will mark an empty parameterized test method as Inconclusive' -TestCases $testCases {
        param($Name)

    }
}

Results in:

Executing script .\Empty.tests.ps1

  Describing Defect: Parameterized Tests do not get marked as Inconclusive when empty.
    [?] will mark an empty test method as Inconclusive 31ms
    [+] will mark an empty parameterized test method as Inconclusive 11ms
Tests completed in 42ms
Tests Passed: 1, Failed: 0, Skipped: 0, Pending: 1, Inconclusive: 0

It would be expected that a parameterized test case is evaluated in the same way as a normal test case.

[it-praktyk]

@Remco-74, IMHO, it's strictly related to #826. I think that a one of these should not be processed.

@nohwnd, are you agree?

[nohwnd]

We should keep both.

• Parameterized tests get executed when no testdata is present. #826 describes what should happen when no test cases are provided.
• This describes what happens if you provide test cases but keep the body of the test "empty" (just having the parameter block and nothing else).

[it-praktyk]

OK, thx for a clarification.

[RemcoKapinga]

Correct, these are two diffrent issues.

I could not locate the code that marks testcases inconclusive when empty, otherwise i could try to submit a pr. Can anyone point me in the right direction?

[nohwnd]

@Remco-74 Sure here it is.

[RemcoKapinga]

Not a PR, but here's a patch.

I've changed the detetion of an empty test to the following (using the Ast of the scriptblock):

#mark empty Its as Pending
#[String]::IsNullOrWhitespace is not available in .NET version used with PowerShell 2
$testIsEmpty = 
    [String]::IsNullOrEmpty($test.Ast.BeginBlock.Statements) -and 
    [String]::IsNullOrEmpty($test.Ast.ProcessBlock.Statements) -and 
    [String]::IsNullOrEmpty($test.Ast.EndBlock.Statements)

if ($PSCmdlet.ParameterSetName -eq 'Normal' -and $testIsEmpty)
{
    $Pending = $true
}

using the following tests (positive and negative):

Describe 'Defect: Parameterized Tests do not get marked as Inconclusive when empty.' {

    BeforeAll {
        $testCases = @{ Name = 'a' }
    }

    It 'will mark an empty test method as Inconclusive' {
        # i am empty
    }

    It 'will mark an empty parameterized test method as Inconclusive' -TestCases $testCases {
        param($Name)
        # i am empty
    }

    It 'will not mark a not empty test method as Inconclusive' {
        Write-Verbose 'i am not empty'
    }

    It 'will not mark a not empty parameterized test method as Inconclusive' -TestCases $testCases {
        param($Name)
        Write-Verbose 'i am not empty'
    }
}

delivers the following (desired) results:

Executing all tests in .\Empty.tests.ps1

Executing script .\Empty.tests.ps1

  Describing Defect: Parameterized Tests do not get marked as Inconclusive when empty.
    [?] will mark an empty test method as Inconclusive 35ms
    [?] will mark an empty parameterized test method as Inconclusive 7ms
    [+] will not mark a not empty test method as Inconclusive 8ms
    [+] will not mark a not empty parameterized test method as Inconclusive 9ms
Tests completed in 61ms
Tests Passed: 2, Failed: 0, Skipped: 0, Pending: 2, Inconclusive: 0

[nohwnd]

Hmm, could you post a PR or it really does not permit you to do that?

[RemcoKapinga]

I created a PR (is my first), I hope this works!

[nohwnd]

The related PR was merged a year ago, closing this.