Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xrp #59

Merged
merged 3 commits into from
Aug 25, 2023
Merged

add xrp #59

merged 3 commits into from
Aug 25, 2023

Conversation

cj4c0b1
Copy link
Contributor

@cj4c0b1 cj4c0b1 commented Jul 12, 2023

No description provided.

@peshay
Copy link
Owner

peshay commented Jul 12, 2023

Thanks for your PR. Can you also add the new currency in the test cases here:
https://github.com/peshay/btcde/blob/ad2fe1b60a8931dca541732c2e01224da6e43a14/tests/test_btcde_func.py#L488C5-L488C5

@cj4c0b1
Copy link
Contributor Author

cj4c0b1 commented Aug 25, 2023

Done

@cj4c0b1
Copy link
Contributor Author

cj4c0b1 commented Aug 25, 2023

====================================================================================================== test session starts ======================================================================================================
platform linux -- Python 3.11.2, pytest-7.4.0, pluggy-1.2.0
rootdir: /home/j4c0b1/btcde
plugins: requests-mock-1.11.0
collected 44 items

tests/test_btcde_func.py ............................................ [100%]

======================================================================================================= warnings summary ========================================================================================================
tests/test_btcde_func.py::TestBtcdeExceptions::test_RequestException
/home/j4c0b1/btcde/.venv/lib/python3.11/site-packages/urllib3/connectionpool.py:1095: InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.bitcoin.de'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings
warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================================= 44 passed, 1 warning in 1.29s =================================================================================================

@peshay peshay merged commit 9acf46f into peshay:master Aug 25, 2023
@cj4c0b1 cj4c0b1 mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants