Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable debug logging #29

Closed
booo opened this issue Jan 30, 2018 · 3 comments
Closed

disable debug logging #29

booo opened this issue Jan 30, 2018 · 3 comments

Comments

@booo
Copy link

booo commented Jan 30, 2018

Debug logging should not be enabled by default for a library.
peshay pushed a commit that referenced this issue Jan 30, 2018
removed DEBUG logging #29
d29fa3d
@peshay
Copy link
Owner

peshay commented Jan 30, 2018

removed for upcoming release 2.2

@peshay peshay closed this as completed Jan 30, 2018
@peshay
Copy link
Owner

peshay commented Jan 30, 2018

Thanks for pointing this out! Btw you could also make Pull Requests if you like

@booo
Copy link
Author

booo commented Jan 30, 2018

Thanks for reacting so fast! I will try to if there is something I find worth changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@booo @peshay