Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty specific import in spark.Request #941

Closed
sf-git opened this issue Nov 14, 2017 · 3 comments
Closed

Jetty specific import in spark.Request #941

sf-git opened this issue Nov 14, 2017 · 3 comments

Comments

@sf-git
Copy link

sf-git commented Nov 14, 2017

Hi,

SparkJava release 2.7.0 has a Jetty specific import org.eclipse.jetty.util.URIUtil; in spark.Request (line 34)

Now org.eclipse.jetty.util should be in your classpath even if you deploy Spark application on external servlet container (Tomcat, etc.)

Thanks.
@tipsy
Copy link
Contributor

tipsy commented Nov 14, 2017

Looks like this PR introduced it: https://github.com/perwendel/spark/pull/872/files

@perwendel
Copy link
Owner

This is bad! We'll fix ASAP and release 2.7.1

perwendel added a commit that referenced this issue Nov 14, 2017
@perwendel
Fixing #941 - Jetty specific import in spark.Request
720d655 
In 2.7.0 release a specific Jetty import was mistakenly added
in spark.Request. This PR fixes this.
perwendel added a commit that referenced this issue Nov 14, 2017
@perwendel
Fixing #941 - Jetty specific import in spark.Request (#942)
5316c0d 
In 2.7.0 release a specific Jetty import was mistakenly added
in spark.Request. This PR fixes this.
@tipsy
Copy link
Contributor

tipsy commented Nov 22, 2017

Fixed and released already.

@tipsy tipsy closed this as completed Nov 22, 2017
@dependabot dependabot bot mentioned this issue Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@perwendel @tipsy @sf-git