Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Commit

Permalink
👷 [ci] temp fix race tests on go 1.14
Browse files Browse the repository at this point in the history
This seems to be a bug in go's crypto lib, which is used by go-ethereum
ethereum/go-ethereum#20731

From the Go 1.14 release notes:

This release adds -d=checkptr as a compile-time option for adding
instrumentation to check that Go code is following unsafe.Pointer safety
rules dynamically. This option is enabled by default (except on Windows)
with the -race or -msan flags, and can be disabled with
-gcflags=all=-d=checkptr=0. Specifically, -d=checkptr checks the
following:

When converting unsafe.Pointer to *T, the resulting pointer must be
aligned appropriately for T.
If the result of pointer arithmetic points into a Go heap object, one of
the unsafe.Pointer-typed operands must point into the same object.

Using -d=checkptr is not currently recommended on Windows because it
causes false alerts in the standard library.
  • Loading branch information
sebastianst committed Mar 6, 2020
1 parent cf761cd commit bc2864d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ unit_tests:
unit_race_tests:
image: golang
stage: tests
script: "go test -timeout 120s -race ./..."
script: "go test -timeout 120s -race -gcflags=all=-d=checkptr=0 ./..."
only:
- merge_requests
when: on_success
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:

- stage: unit_race_tests
script:
- go test -timeout 120s -race ./...
- go test -timeout 120s -race -gcflags=all=-d=checkptr=0 ./...

0 comments on commit bc2864d

Please sign in to comment.