Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got Camera Feed Working With Republisher #93

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Nov 4, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

The app previously subscribed directly to the camera feed being published from nano. This is a problem because, due to potential ROS2 performance issues or nano compute issues, too many concurrent subscriptions will result in dropped messages. This PR addresses this by instead having the app subscribe to the republished local camera feed, which is published from a more powerful computer. This PR also makes a few smaller changes, described in the commit messages.

Explain how this pull request was tested, including but not limited to the below checkmarks.

  1. Pull the latest code for all directories and re-build.
  2. ros2 launch feeding_web_app_ros2_test feeding_web_app_dummy_nodes_launch.xml run_motion:=false
  3. ros2 launch ada_feeding_perception ada_feeding_perception.launch.py
  4. Open the web app by navigating to feedingwebapp and running npm start
  • Load the live video feed from the web app, and verify that it shows up.
  • In the launchfile, modify the name of the rgb_path to be 2022_11_01_ada_picks_up_carrots_camera_compressed_ft_tf.mp4. Keep the rest of the path the same.
  • Run RVIZ and load the camera feed. Verify that the web app feed has no visual lag compared to the RVIZ camera feed.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N/A] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • [N/A] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit ef0f61c into main Nov 4, 2023
4 checks passed
@amalnanavati amalnanavati deleted the amaln/camera_local branch November 4, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant