Got Camera Feed Working With Republisher #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
The app previously subscribed directly to the camera feed being published from
nano
. This is a problem because, due to potential ROS2 performance issues or nano compute issues, too many concurrent subscriptions will result in dropped messages. This PR addresses this by instead having the app subscribe to the republished local camera feed, which is published from a more powerful computer. This PR also makes a few smaller changes, described in the commit messages.Explain how this pull request was tested, including but not limited to the below checkmarks.
ros2 launch feeding_web_app_ros2_test feeding_web_app_dummy_nodes_launch.xml run_motion:=false
ros2 launch ada_feeding_perception ada_feeding_perception.launch.py
feedingwebapp
and runningnpm start
rgb_path
to be2022_11_01_ada_picks_up_carrots_camera_compressed_ft_tf.mp4
. Keep the rest of the path the same.Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)