Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated infra changes from RSS Demo #122

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

egordon
Copy link
Contributor

@egordon egordon commented Feb 2, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

  1. Add better logging.
  2. Make Auto-Continue the default for DetectingFace
  3. Allow for changing number of MaskButtons between renders (e.g., because if the masks are too close to the edge of the screen, SegmentFromPoint might return fewer than 3 masks)

Explain how this pull request was tested, including but not limited to the below checkmarks.

Tested over the course of the 1/22-1/24 user studies.


Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • [N/A] Thoroughly test your code's functionality, including unintended uses.
  • [N/A] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • [N/A] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@egordon egordon requested a review from amalnanavati February 2, 2024 23:42
@amalnanavati amalnanavati merged commit c92f2d2 into main Feb 7, 2024
4 checks passed
@amalnanavati amalnanavati deleted the rss_infra_push branch February 7, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants