Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override AutoContinue if moving back from mouth #119

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Jan 17, 2024

This PR overrides auto-continue if the robot arrived at DetectingFace through the MoveFromMouth state. This is to avoid the case where the user mistakenly presses back, and then it automatically moves to their mouth.

  • Check auto-continue, go to detecting face, verify that it continues.
  • From BiteDone, go back to staging config, verify it doesn't auto-continue.
  • Pause MoveToMouth and go back, verify it doesn't auto-continue.

This PR also adds better error handling to the WebRTC server.


Before creating a pull request

  • Format React code with npm run format

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 19b671d into main Jan 17, 2024
4 checks passed
@amalnanavati amalnanavati deleted the demo/01-16 branch January 17, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant