Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the viewer has an underlying world, skeleton markers corresponding to skeletons in the world that have been removed continued to be visualized. When the world removes the skeleton, the
SkeletonPtr
is non-nullptr and therefore the control did not reach the line that erases the marker from the map. This PR reorganizes the code for correction.Tested via
herb3_demos
scripts for addition, deletion and updates to skeletons.@brianhou: As a side: I wonder if we should re-introduce the
WorldInteractiveMarkerViewer
, not in its previous state but just to reimplement theupdateSkeletonMarkers()
function to have fewer if conditions.Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md