Fix Travis CI builds #524
Fix Travis CI builds #524
Conversation
Update DART version to match PPA (unblocks other repos like `libada` that are dealing with an interface change).
|
LGTM! @egordon could you update CHANGELOG.md as well? |
|
@gilwoolee Note that this update breaks Travis (since trusty doesn't have DART v6.8.2). I'm going to see if Travis plays nice with xenial. |
Co-Authored-By: egordon <[email protected]>
| @@ -1,4 +1,4 @@ | |||
| dist: trusty | |||
| dist: xenial | |||
There was a problem hiding this comment.
Xenial build still has an issue: #363
There was a problem hiding this comment.
Double-check that this is still an issue in CI, since I believe in the launch scripts I forced it to pull OMPL 1.0 rather than 1.2 to get around this.
There was a problem hiding this comment.
Looks like it's still failing? https://travis-ci.org/personalrobotics/aikido/jobs/559769715
| // Run the IK solver. If it succeeds, return the solution. | ||
| if (mInverseKinematics->solve(true)) | ||
| // Run the IK solver. If an exact solution is computed, apply it to the skeleton. | ||
| if (mInverseKinematics->solveAndApply(true)) |
There was a problem hiding this comment.
It seems AIKIDO still support Ubuntu 14.04. The latest DART version available in Ubuntu 14.04 is 6.6.2. I would change this to be backward compatible something like:
#if DART_VERSION_AT_LEAST(6,8,0)
if (mInverseKinematics->solveAndApply(true))
#else
if (mInverseKinematics->solve(true))
#endif
|
The CI tests are failing because it uses deprecated I suggest following possible solutions: |
.ci/install_linux_cmake.sh
Outdated
| $SUDO apt-get -y install python3-pip -y | ||
| $SUDO pip3 install pytest -U | ||
|
|
||
| if [ $(lsb_release -sc) = "trusty" ]; then |
There was a problem hiding this comment.
Is there a reason that the trusty, xenial, and bionic cases are duplicated? (And cosmic and disco.)
There was a problem hiding this comment.
Nope. Just for the case that they require different scripts. Feel free to merge them into two groups.
|
Just to be clear, it looks like this leaves
in the allowed failures list. That's fine for now, but we should continue to discuss which ones we care about. |
|
It seems the new macOS image is unstable. The last commit is just to retrigger with a new instance. |
Update DART version to match PPA (unblocks other repos like
libadathat are dealing with an interface change).Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md