Enhancement/pose estimator #497

yskim041 · 2019-01-27T04:07:17Z

Cleaned up hacks for nips demo.
Added DetectedObject class
PoseEstimatorModule gets an object's unique id and additional information in JSON format from the text field of a Marker. DetectedObject is a wrapper for the information and delegates a detected object.

Before creating a pull request

Document new methods and classes
Format code with make format

Before merging a pull request

Set version target by selecting a milestone on the right side
Summarize this change in CHANGELOG.md

brianhou

Looks good! Requested some minor changes, mostly since I'm still unclear what JSON information is being sent by the external pose estimator.

src/perception/PoseEstimatorModule.cpp

include/aikido/perception/PoseEstimatorModule.hpp

…nalrobotics/aikido into enhancement/pose_estimator

codecov · 2019-02-03T21:06:54Z

Codecov Report

Merging #497 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #497   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files         262      262           
  Lines        6712     6712           
=======================================
  Hits         5227     5227           
  Misses       1485     1485

include/aikido/perception/DetectedObject.hpp

src/perception/DetectedObject.cpp

include/aikido/perception/DetectedObject.hpp

src/perception/PoseEstimatorModule.cpp

include/aikido/perception/DetectedObject.hpp

…e UIDs

…a_demos

egordon · 2019-02-13T01:22:17Z

@brianhou @gilwoolee Ready for re-review!

include/aikido/perception/PerceptionModule.hpp

src/perception/PoseEstimatorModule.cpp

egordon · 2019-02-13T18:12:21Z

@gilwoolee Ready for re-review!

brianhou

I think Travis is failing because of formatting issues, so feel free to ping if you need help reformatting after your changes.

CHANGELOG.md

include/aikido/perception/DetectedObject.hpp

src/perception/PoseEstimatorModule.cpp

Added non-refactor changes from Brian Co-Authored-By: egordon <[email protected]>

…tabase

gilwoolee

Getting close! Left a few nit comments but otherwise looks good to me.

include/aikido/perception/AssetDatabase.hpp

include/aikido/perception/DetectedObject.hpp

include/aikido/perception/PerceptionModule.hpp

include/aikido/perception/PoseEstimatorModule.hpp

src/perception/DetectedObject.cpp

src/perception/PoseEstimatorModule.cpp

gilwoolee

Three nit comments to go!

include/aikido/perception/DetectedObject.hpp

include/aikido/perception/PoseEstimatorModule.hpp

src/perception/PoseEstimatorModule.cpp

yskim041

Looks good to me. I leave one comment. Please address it, and then this PR should be fine for me.

gilwoolee added 2 commits January 26, 2019 19:56

Pose estimator enhancement

e2440aa

Add cpp classes in perception

da1b722

yskim041 requested a review from gilwoolee January 27, 2019 04:07

yskim041 self-assigned this Jan 27, 2019

yskim041 requested review from schmittlema and egordon and removed request for egordon and schmittlema January 27, 2019 04:08

clean up hancks for demo

e27ecaf

yskim041 added this to the Aikido 0.3.0 milestone Jan 27, 2019

yskim041 requested review from schmittlema, egordon and brianhou January 27, 2019 04:59

update CHANGELOG.md

fb1bfc0

brianhou suggested changes Feb 2, 2019

View reviewed changes

add a new class DetectedObject and update PoseEstimatorModule

61a3a24

yskim041 requested review from wagnew3 and removed request for schmittlema February 3, 2019 06:25

yskim041 added the pr: work-in-progress Calls for preliminary review of the PR. Remove when PR is ready for complete review. label Feb 3, 2019

yskim041 and others added 5 commits February 2, 2019 22:46

minor fixes

853e11b

Merge branch 'master' into enhancement/pose_estimator

f8c7758

remove the projection height from PoseEstimatorModule

4ce2f50

Merge branch 'enhancement/pose_estimator' of https://github.com/perso…

e84d6fd

…nalrobotics/aikido into enhancement/pose_estimator

Merge branch 'master' into enhancement/pose_estimator

e874ec9

document DetectedObject class

286359d

yskim041 removed the pr: work-in-progress Calls for preliminary review of the PR. Remove when PR is ready for complete review. label Feb 4, 2019

yskim041 force-pushed the enhancement/pose_estimator branch from 1fdaf4d to 286359d Compare February 4, 2019 04:31

change 'id' -> 'uid'

062f16f

gilwoolee suggested changes Feb 5, 2019

View reviewed changes

Merge branch 'master' into enhancement/pose_estimator

b03e20f

gilwoolee requested a review from aditya-vk as a code owner February 11, 2019 06:34

yskim041 added the pr: work-in-progress Calls for preliminary review of the PR. Remove when PR is ready for complete review. label Feb 11, 2019

yskim041 and others added 5 commits February 12, 2019 10:51

change the way to parse a Marker message

cc58f6b

Allow nullptr for detectedObjects argument

c973cc0

Added robustness against bad YAML strings, plus more easily-parse-abl…

bc3bf1b

…e UIDs

Fixed documentation per comments, tested with simple_perception in ad…

527e462

…a_demos

Added default argument to detectedObjects.

1633676

gilwoolee suggested changes Feb 13, 2019

View reviewed changes

Fixed comments on pull request

9732051

Indigo compatibility (no DELETEALL)

36d422e

brianhou suggested changes Feb 13, 2019

View reviewed changes

brianhou and others added 3 commits February 13, 2019 13:23

Apply suggestions from code review

7c3971a

Added non-refactor changes from Brian Co-Authored-By: egordon <[email protected]>

Applied comments from PR review: refactored ObjectDatabase to AssetDa…

79f921a

…tabase

Clang formatted

af32515

gilwoolee suggested changes Feb 14, 2019

View reviewed changes

Fixed PR comments.

9581880

yskim041 commented Feb 14, 2019

View reviewed changes

src/perception/PoseEstimatorModule.cpp Outdated Show resolved Hide resolved

gilwoolee suggested changes Feb 14, 2019

View reviewed changes

include/aikido/perception/DetectedObject.hpp Outdated Show resolved Hide resolved

include/aikido/perception/PoseEstimatorModule.hpp Outdated Show resolved Hide resolved

src/perception/PoseEstimatorModule.cpp Outdated Show resolved Hide resolved

yskim041 commented Feb 14, 2019

View reviewed changes

egordon added 2 commits February 13, 2019 18:12

Move vector push to end of for loop

21460a9

Final PR nits.

92fa686

gilwoolee approved these changes Feb 14, 2019

View reviewed changes

brianhou approved these changes Feb 14, 2019

View reviewed changes

gilwoolee removed the pr: work-in-progress Calls for preliminary review of the PR. Remove when PR is ready for complete review. label Feb 14, 2019

gilwoolee merged commit a1ef21a into master Feb 14, 2019

gilwoolee deleted the enhancement/pose_estimator branch February 14, 2019 07:52

gilwoolee mentioned this pull request Feb 17, 2019

Demo/nips updates #476

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/pose estimator #497

Enhancement/pose estimator #497

yskim041 commented Jan 27, 2019 •

edited

Loading

brianhou left a comment

codecov bot commented Feb 3, 2019 •

edited

Loading

egordon commented Feb 13, 2019

egordon commented Feb 13, 2019

brianhou left a comment

gilwoolee left a comment

gilwoolee left a comment

yskim041 left a comment

Enhancement/pose estimator #497

Enhancement/pose estimator #497

Conversation

yskim041 commented Jan 27, 2019 • edited Loading

brianhou left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 3, 2019 • edited Loading

Codecov Report

egordon commented Feb 13, 2019

egordon commented Feb 13, 2019

brianhou left a comment

Choose a reason for hiding this comment

gilwoolee left a comment

Choose a reason for hiding this comment

gilwoolee left a comment

Choose a reason for hiding this comment

yskim041 left a comment

Choose a reason for hiding this comment

yskim041 commented Jan 27, 2019 •

edited

Loading

codecov bot commented Feb 3, 2019 •

edited

Loading