Update for DART 6.7 #480
Merged
Update for DART 6.7 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brianhou
previously approved these changes
Jan 15, 2019
|
Please note that DART 6.7 is not available on Trusty. Let's either drop supporting Trusty for AIKIDO or change this PR to support both of DART 6.6 and DART 6.7. |
|
We'll discuss during lab meeting on Friday, but I'm heavily leaning toward just dropping Trusty support. |
Use clone() instead of cloneSkeleton() for DART < 6.7
|
Updated to support both of DART 6.6 and DART 6.7 so that we now can merge this regardless of whether to support Trusty or not. Once AIKIDO drops supporting Trusty, the if-preprocessors can be simply removed. |
brianhou
previously approved these changes
Jan 17, 2019
|
Could someone please run |
|
Never mind! It's done! |
brianhou
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use recommended APIs instead of deprecated corresponding.
Note that this PR won't pass the CIs (for Ubuntu >= 14.04) until the issues of gtest and
make_unique(). I breakdown #479 into smaller ones to make the review process, and this is one of them.Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md