Fix compilation errors with Eigen 3.3.5 #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 256 256
Lines 6185 6185
=======================================
Hits 4887 4887
Misses 1298 1298
|
gilwoolee
pushed a commit
that referenced
this pull request
Jan 21, 2019
* Add @jslee02's fix for Eigen 3.3.5 bug. * Update CHANGELOG.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #451. I've tested this locally with both 3.3.4 and 3.3.5.
We should probably try to figure out how to take advantage of knowing the correct fixed-size output vector, but maybe this isn't possible.
Before creating a pull request
make formatBefore merging a pull request
CHANGELOG.md