-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in collision checking of VPF #303
Fix bug in collision checking of VPF #303
Conversation
Now the test will fail because of a bug in the iterator of An exception will be throw
I created another PR #305 to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VFP test is still failing. Is this expected?
CHANGELOG.md
Outdated
@@ -29,7 +29,7 @@ | |||
* Planner | |||
|
|||
* Added World class: [#243](https://github.com/personalrobotics/aikido/pull/243), [#252](https://github.com/personalrobotics/aikido/pull/252), [#265](https://github.com/personalrobotics/aikido/pull/265) | |||
* Added vector field planner [#246](https://github.com/personalrobotics/aikido/pull/246), [#262](https://github.com/personalrobotics/aikido/pull/262), [#268](https://github.com/personalrobotics/aikido/pull/268) | |||
* Added vector field planner [#246](https://github.com/personalrobotics/aikido/pull/246), [#262](https://github.com/personalrobotics/aikido/pull/262), [#268](https://github.com/personalrobotics/aikido/pull/268), [#303](https://github.com/personalrobotics/aikido/pull/303) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to 0.3.0. 0.2.0 is released.
It is still failing for the same reason. |
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 81.01% 81.06% +0.04%
==========================================
Files 204 204
Lines 6005 6005
==========================================
+ Hits 4865 4868 +3
+ Misses 1140 1137 -3
|
Fix the wrong way of calling
StepSequence
in collision checking of VPF.Document new methods and classes (N/A)
Format code with
make format
Set version target by selecting a milestone on the right side
Summarize this change in
CHANGELOG.md
Add unit test(s) for this change (N/A)