Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MetaSkeletonStateSpaceSaver implementation to a cpp file. #273

Merged
merged 5 commits into from
Dec 2, 2017
Merged

Move MetaSkeletonStateSpaceSaver implementation to a cpp file. #273

merged 5 commits into from
Dec 2, 2017

Conversation

gilwoolee
Copy link
Contributor

@gilwoolee gilwoolee commented Dec 2, 2017 •
edited
Loading

This PR moves MetaSkeletonStateSpaceSaver's implementation from a header file to a cpp file. The current version results in multiple definition error when two classes import MetaSkeletonStateSpaceSaver.

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@gilwoolee gilwoolee requested a review from jslee02 December 2, 2017 03:12
jslee02
jslee02 approved these changes Dec 2, 2017
View reviewed changes
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This looks good to me. Just made two comments about style.

tests/statespace/dart/test_MetaSkeletonStateSpaceSaver.cpp Outdated

TEST(MetaSkeletonStateSpaceSaver, MetaSkeletonStateSpaceReturnsToOriginal)
{

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please remove this empty line.

src/statespace/dart/MetaSkeletonStateSpaceSaver.cpp Outdated
@@ -11,6 +14,7 @@ MetaSkeletonStateSpaceSaver::MetaSkeletonStateSpaceSaver(
{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please add // Do nothing to indicate this function is intentionally empty.

@gilwoolee gilwoolee added this to the Aikido 0.2.0 milestone Dec 2, 2017
@gilwoolee gilwoolee self-assigned this Dec 2, 2017
@gilwoolee gilwoolee merged commit aac3840 into master Dec 2, 2017
@gilwoolee gilwoolee deleted the bugfix/MetaSkeletonStateSpaceSaver branch December 2, 2017 03:32
gilwoolee added a commit that referenced this pull request Jan 21, 2019
@gilwoolee
Move MetaSkeletonStateSpaceSaver implementation to a cpp file. (#273)
a0084f1 
* Move MetaSkeletonStateSpaceSaver-impl to cpp file

* Add tests for MetaSkeletonStateSpaceSaver

* Remove unused header from test_MetaSkeletonStateSpaceSaver

* Address PR review comments

* Added PR change to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslee02 jslee02 jslee02 approved these changes

Assignees

@gilwoolee gilwoolee

Labels
None yet
Projects
None yet
Milestone
Aikido 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gilwoolee @jslee02