Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WorldInteractiveMarkerViewer. #242

Merged
merged 6 commits into from
Oct 23, 2017

Conversation

brianhou
Copy link
Contributor

@brianhou brianhou commented Oct 18, 2017

This subclasses aikido::rviz::InteractiveMarkerViewer to create a viewer for a dart::simulation::World. This would automatically update the viewer as skeletons are added to the World, which is a first step toward using them properly in all of our demo scripts.

@psigen mentioned that dart::simulation::World has some additional overhead if we aren't doing things with dynamics. I'm using World for now for lack of something better in DART, but we should seriously think about a better longer-term solution.

Other issues:

  • There doesn't seem to be a mutex associated with Worlds, so there might be some thread-safety issues here?
  • Cloning a World doesn't replicate the transforms or the joint states. This line in DART suggests that this is still a TODO...

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@brianhou brianhou requested review from jslee02 and gilwoolee October 18, 2017 04:43
@brianhou brianhou changed the base branch from master to enhancement/brianhou/world October 18, 2017 22:49
@brianhou brianhou force-pushed the enhancement/brianhou/WorldInteractiveMarkerViewer branch from 24ddd8a to 3f7b578 Compare October 18, 2017 22:50
@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   70.92%   70.92%           
=======================================
  Files         173      173           
  Lines        5118     5118           
  Branches      809      809           
=======================================
  Hits         3630     3630           
  Misses       1000     1000           
  Partials      488      488

@brianhou
Copy link
Contributor Author

When I'm using this new viewer class in the (poorly-named) block_stacking demo, I sometimes get this error when I exit the script:

*** Error in `./devel/bin/block_stacking': corrupted double-linked list: 0x0000000000660e40 ***

This StackOverflow answer suggests that heap overflow might be to blame, but I'm not sure where this could be happening. If anyone sees something that could be causing that issue, please let me know!

@brianhou brianhou force-pushed the enhancement/brianhou/WorldInteractiveMarkerViewer branch from 16ccf10 to 4dc96a0 Compare October 18, 2017 23:30
@brianhou brianhou added this to the Aikido 0.2.0 milestone Oct 19, 2017
@brianhou brianhou changed the base branch from enhancement/brianhou/world to master October 20, 2017 05:22
@brianhou brianhou force-pushed the enhancement/brianhou/WorldInteractiveMarkerViewer branch from 4dc96a0 to 13ba689 Compare October 20, 2017 05:27
@brianhou brianhou merged commit 2857b48 into master Oct 23, 2017
@aditya-vk aditya-vk deleted the enhancement/brianhou/WorldInteractiveMarkerViewer branch February 22, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant