-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WorldInteractiveMarkerViewer. #242
Add WorldInteractiveMarkerViewer. #242
Conversation
24ddd8a
to
3f7b578
Compare
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 70.92% 70.92%
=======================================
Files 173 173
Lines 5118 5118
Branches 809 809
=======================================
Hits 3630 3630
Misses 1000 1000
Partials 488 488 |
When I'm using this new viewer class in the (poorly-named) block_stacking demo, I sometimes get this error when I exit the script:
This StackOverflow answer suggests that heap overflow might be to blame, but I'm not sure where this could be happening. If anyone sees something that could be causing that issue, please let me know! |
16ccf10
to
4dc96a0
Compare
Replace dart::simulation::World with aikido::planner::World in perception modules.
4dc96a0
to
13ba689
Compare
This subclasses
aikido::rviz::InteractiveMarkerViewer
to create a viewer for adart::simulation::World
. This would automatically update the viewer as skeletons are added to theWorld
, which is a first step toward using them properly in all of our demo scripts.@psigen mentioned that
dart::simulation::World
has some additional overhead if we aren't doing things with dynamics. I'm usingWorld
for now for lack of something better in DART, but we should seriously think about a better longer-term solution.Other issues:
World
s, so there might be some thread-safety issues here?World
doesn't replicate the transforms or the joint states. This line in DART suggests that this is still a TODO...Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md