Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code format: tests #239

Merged
merged 3 commits into from
Oct 13, 2017
Merged

Code format: tests #239

merged 3 commits into from
Oct 13, 2017

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Oct 13, 2017 •
edited
Loading

Resolves #231

Before creating a pull request

  • Document new methods and classes (nothing new)
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (nothing new to test)

@jslee02 jslee02 added this to the Aikido 0.2.0 milestone Oct 13, 2017
@jslee02 jslee02 requested a review from brianhou October 13, 2017 17:20
@jslee02 jslee02 changed the title Enhancement/code format tests Code format: tests Oct 13, 2017
@codecov
Copy link

codecov bot commented Oct 13, 2017 •
edited
Loading

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   70.78%   70.78%           
=======================================
  Files         172      172           
  Lines        5055     5055           
  Branches      802      802           
=======================================
  Hits         3578     3578           
  Misses        993      993           
  Partials      484      484

@jslee02 jslee02 merged commit 74794e4 into master Oct 13, 2017
@jslee02 jslee02 deleted the enhancement/code_format_tests branch October 13, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhou brianhou brianhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @brianhou