save joint limits of space in MetaSkeletonStateSpaceSaver #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhou
suggested changes
Sep 25, 2017
| @@ -16,7 +18,20 @@ MetaSkeletonStateSpaceSaver::~MetaSkeletonStateSpaceSaver() | |||
| std::cerr << "[MetaSkeletonStateSpaceSaver] The number of DOFs in the " | |||
| << "MetaSkeleton does not match the saved state."; | |||
There was a problem hiding this comment.
saved state -> saved position.
| if (mPositionLowerLimits.size() != mSpace->getMetaSkeleton()->getNumDofs()) | ||
| { | ||
| std::cerr << "[MetaSkeletonStateSpaceSaver] The number of DOFs in the " | ||
| << "MetaSkeleton does not match the save joint lower limits."; |
There was a problem hiding this comment.
save joint lower limits -> saved position lower limits.
| if (mPositionUpperLimits.size() != mSpace->getMetaSkeleton()->getNumDofs()) | ||
| { | ||
| std::cerr << "[MetaSkeletonStateSpaceSaver] The number of DOFs in the " | ||
| << "MetaSkeleton does not match the save joint upper limits."; |
There was a problem hiding this comment.
save joint upper limits -> saved position upper limits.
jslee02
approved these changes
Sep 26, 2017
brianhou
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving personalrobotics/aikido #218