Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: renaming spin to step and removing template from RosTrajectoryExecutor #189

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Bugfix: renaming spin to step and removing template from RosTrajectoryExecutor #189

merged 1 commit into from
Apr 23, 2017

Conversation

gilwoolee
Copy link
Contributor

This PR renames spin to step so that the method properly overrides TrajectoryExecutor::step. It also removes templating of connectionTimeout and connectionPollingPeriod in the constructor.

@gilwoolee gilwoolee requested review from mkoval and jslee02 April 22, 2017 23:49
@gilwoolee gilwoolee changed the title Renaming spin to step and removing template Bugfix: renaming spin to step and removing template from RosTrajectoryExecutor Apr 22, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 78.813% when pulling 101394e on bugfix/RosTrajExecutor into 4af95ae on master.

@gilwoolee gilwoolee merged commit 4c08ac5 into master Apr 23, 2017
@gilwoolee gilwoolee deleted the bugfix/RosTrajExecutor branch April 23, 2017 00:26
jslee02 pushed a commit that referenced this pull request Apr 23, 2017
@gilwoolee @jslee02
Renaming spin to step and removing template (#189)
1f7aba6
@jslee02 jslee02 added this to the Aikido 0.1.0 milestone May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoval mkoval mkoval approved these changes

@jslee02 jslee02 Awaiting requested review from jslee02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aikido 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gilwoolee @coveralls @mkoval @jslee02