Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Travis builds #18

Closed
psigen opened this issue Feb 24, 2016 · 2 comments · Fixed by #26
Closed

Set up Travis builds #18

psigen opened this issue Feb 24, 2016 · 2 comments · Fixed by #26

Comments

@psigen
Copy link
Member

psigen commented Feb 24, 2016

As mentioned by @mkoval in #12, we should set up Travis builds for automated testing. A few questions:

@mkoval
Copy link
Member

mkoval commented Feb 24, 2016

Should we build standalone, catkin, or both? (I prefer standalone, but maybe both since we have aikido_rviz, etc.)

I plan to use the pr-cleanroom architecture I already have setup, which builds aikido in a Catkin workspace. It also sense to build aikido (without any of the ROS-dependent addon packages, like aikido_rviz) to verify that no ROS dependencies crept in, but I don't plan on doing this myself. 😉

Which version(s) of kido should we test against?

We're currently stuck building against master because we're using bleeding-edge features. We'll need to revisit this once things settle down. Hopefully we can use the official Debian builds.

Can we use Travis's container-based infrastructure?

No. There is a request open to whitelist ROS, but it has not yet been approved. I don't think the container-based infrastructure will ever be a viable choice for us unless Travis removes the Apt whitelisting requirement. Travis is pretty bad about approving whitelist requests: there are 182 requests open, some pending for 9 months, and only 20 have been approved. I would be shocked if they ever approve ROS, which has hundreds of packages from different authors.

@jslee02
Copy link
Member

jslee02 commented Mar 18, 2016

I'm also against to use container-based infrastructure. I have three PRs waiting to be reviewed but as @mkoval said they never approved. Also, Simbody found that it runs much slower, which is not the expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants