Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivated by
feeding_web_interface
#113.If MoveToMouth fails due to approaching a singularity, MoveFromMouth will also fail. This PR addresses that by adding cartesian motion as a fallback to MoveFromMouth.
Further, since cartesian motion tends to fail if the arm is tilted, this PR also removes the arm tilt at the mouth.
Finally, to help streamline the app and improve retrying actions, this PR removes the combo actions of
MoveFromMouthToAbovePlate
andMoveFromMouthToRestingPosition
. Instead, the app will achieve the desired behavior by callingMoveFromMouth
followed by eitherMoveAbovePlate
orMoveToRestingPosition
Testing procedure
feeding_web_interface
#113. Do many MoveToMouth / MoveFromMouth with different distances, verify it works.Before opening a pull request
python3 -m black .
ada_feeding
directory, run:pylint --recursive=y --rcfile=.pylintrc .
.Before Merging
Squash & Merge