Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move From Mouth Fallback #155

Merged
merged 7 commits into from
Jan 16, 2024
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Jan 13, 2024

Description

Motivated by feeding_web_interface#113.

If MoveToMouth fails due to approaching a singularity, MoveFromMouth will also fail. This PR addresses that by adding cartesian motion as a fallback to MoveFromMouth.

Further, since cartesian motion tends to fail if the arm is tilted, this PR also removes the arm tilt at the mouth.

Finally, to help streamline the app and improve retrying actions, this PR removes the combo actions of MoveFromMouthToAbovePlate and MoveFromMouthToRestingPosition. Instead, the app will achieve the desired behavior by calling MoveFromMouth followed by either MoveAbovePlate or MoveToRestingPosition

Testing procedure

  • Tested with feeding_web_interface#113. Do many MoveToMouth / MoveFromMouth with different distances, verify it works.
  • Comment out the servo part of the fallback (equivalent to it failing), repeat the above, and verify that cartesian tends to succeed.

Before opening a pull request

  • Format your code using black formatter python3 -m black .
  • Run your code through pylint and address all warnings/errors. The only warnings that are acceptable to not address is TODOs that should be addressed in a future PR. From the top-level ada_feeding directory, run: pylint --recursive=y --rcfile=.pylintrc ..

Before Merging

  • Squash & Merge

@amalnanavati amalnanavati merged commit 3f02b5f into ros2-devel Jan 16, 2024
@amalnanavati amalnanavati deleted the amaln/move_from_mouth_fallback branch January 16, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant