Allow special characters (like #) #71
Conversation
|
Fixes #66 |
| return url; | ||
| } | ||
|
|
||
| function request(fullUrl, options) { |
There was a problem hiding this comment.
I wouldn't recommend changing this file to perform this work. For one, splitting the URL like this is a bit redundant and unsafe. Ultimately only the path needs encoding (here), which could be done in the interface files like putFile.js.
Ideally there'd be some helper method to perform the encoding like encodeRequestPath(path) that you could use on all get/put/mkdir requests.
There was a problem hiding this comment.
I tried a bunch of different splitting methods, particularly url = new URL(...) however since something like
https://webdav-server.com/webdav/file #1.json has the # character, the path is only parsed up to that point (#1.json is removed). How would you go about parsing?
I'll look into moving the encoding around. I went this way to keep the code more DRY.
|
Thanks for submitting @nickmisasi13 - I've commented regarding where the work has been done. I would prefer it to be performed in the actual request methods themselves rather than the request getter. Also the tests are failing, which must pass for a review to go through. |
|
Thanks for the work, but unfortunately I'm going to close this one in favour of #76. The new PR addresses the encoding for only the paths. |
Currently the module does not support uploading files with a name like
Data #1.csv. I've added functionality to parse the link and encode any special characters before it makes any requests to the Webav server.