Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom.js #231

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Conversation

anatolyukropov
Copy link
Contributor

This is a custom method, so i think he must give me an oppotunity to work with files.
For example this method set props:
const contents = await this.webDavClient.customRequest(path, {
method: 'PROPPATCH',
headers: {
Accept: '/',
},
data: propertyupdate.toXML(),
responseType: 'application/xml; charset="utf-8"',
});
But couse of '/' i can set props only to dirs.
Can you remove this join '/', or make some props like, file with file = true remove '/'

This is a custom method, so i think he must give me an oppotunity to work with files. 
For example this method set props: 
const contents = await this.webDavClient.customRequest(path, {
        method: 'PROPPATCH',
        headers: {
          Accept: '*/*',
        },
        data: propertyupdate.toXML(),
        responseType: 'application/xml; charset="utf-8"',
      });
But couse of '/' i can set props only to dirs. 
Can you remove this join '/', or make some props like, file with fill remove '/'
@perry-mitchell
Copy link
Owner

I agree that the forced addition of / looks weird, especially for a custom request. remotePath could easily include the ending slash if required. Not sure I want to rush into this change as it could have downstream consequences. I'll see if I can't find the prior contributors for this feature to ask them about their usage.

@perry-mitchell perry-mitchell self-assigned this Dec 11, 2020
@perry-mitchell
Copy link
Owner

@ubarsaiyan FYI, if you have a moment..

@perry-mitchell
Copy link
Owner

Upon closer inspection it seems like this was added over a year ago.. probably not fresh in anyone's minds right now. Let me have a think on it and will get back to it asap.

Copy link
Owner

@perry-mitchell perry-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it blocks accessing files, as mentioned.

@perry-mitchell perry-mitchell merged commit eb85503 into perry-mitchell:master Dec 26, 2020
@anatolyukropov anatolyukropov deleted the patch-1 branch December 26, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants