Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussed fix for #147 #176

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Conversation

Glebka
Copy link
Contributor

@Glebka Glebka commented Oct 6, 2019

So I created a PR that implements what was discussed in #147:
I added an ability to pass Readable stream as data argument + created a test for it.

@perry-mitchell, please review.

@perry-mitchell
Copy link
Owner

Hi @Glebka - Thanks for this! Seems the tests are failing but are mostly unrelated.. That being said, I don't have time right now to find the issue.. Would there be any chance you might take a took?

Seems to be xvfb failing on web, which I can try restarting now, and seems that some dependency updated on the node side (Hapi rubbish most likely) to add ... spreading, which doesn't work on Node 6.

I'll be supporting node 6 until a new version is released - soon.

@perry-mitchell
Copy link
Owner

Ok, upon closer look I'm not sure that this will work for downstream users in the browser. I think it's best that we don't use native node modules, especially streams and other file/IO items, as they don't transpile or transpile poorly.

I'll leave this open for dicussion, but I'm not sure how we can move forward with this in its current state.

@perry-mitchell
Copy link
Owner

@Glebka I've updated the PR to include checks for the new web version, hope you don't mind. Waiting to see if the tests pass now.

@perry-mitchell perry-mitchell merged commit a0e2273 into perry-mitchell:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants