Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for tests has doubled overnight #2498

Closed
JJ opened this issue Dec 6, 2018 · 5 comments
Closed

Time for tests has doubled overnight #2498

JJ opened this issue Dec 6, 2018 · 5 comments
Labels
meta RFCs, general discussion, writing style, repository organization, etc.

Comments

@JJ
Copy link
Contributor

JJ commented Dec 6, 2018

The problem

screenshot from 2018-12-06 11 21 11

It's gone from ~500 seconds to ~ 1000 seconds. @finanalyst 's PR #2497 which is set to eliminate disambiguation will reduce time, but it's still a problem.

Suggestions

The problem seems to be with the change from 2018.10 to 2018.11 in the Docker container used. At the same time, Travis has changed its infrastructure to use virtual machines instead of containers. I don't know which one is to blame for this, but going back to ~30 minutes for test is unacceptable.

@JJ JJ added the meta RFCs, general discussion, writing style, repository organization, etc. label Dec 6, 2018
@JJ
Copy link
Contributor Author

JJ commented Dec 6, 2018

I would say it's a problem with the Perl 6 version. The whateverable-based tests, which uses an up-to-date executable, always took longer. It's been only when the docker container has been updated when it started to take longer with it.
I am going to check with other versions, to see if that's the thing. Has there been any change lately that might explain that?

JJ added a commit that referenced this issue Dec 6, 2018
It's just eight seconds, but it's not really needed. This goes towards
solving #2498.
@JJ
Copy link
Contributor Author

JJ commented Dec 6, 2018

Still, there's some other thing that we have not considered: the fact that now all files are being built from source.
Also, the travis cache is activated, but I'm not sure we are really using it. Not sure if we really can, htmlify.p6 generates everything from scratch every time...

JJ added a commit that referenced this issue Dec 6, 2018
This goes towards helping #2498, but also is a test that we could
proceed with #2499.
@AlexDaniel
Copy link
Member

What's the situation now? Is it better?

@JJ
Copy link
Contributor Author

JJ commented Dec 13, 2018

It's improved after elimination of the generation of the disambiguation files... That really took a long time.

@AlexDaniel
Copy link
Member

I'm not running any tests, just created a ticket because the issue seemed serious. If there is no problem (in rakudo) please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta RFCs, general discussion, writing style, repository organization, etc.
Projects
None yet
Development

No branches or pull requests

3 participants
@JJ @AlexDaniel and others