Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of minor versions #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferki
Copy link

@ferki ferki commented Jun 15, 2020

This PR fixes the documentation for minor versions of Windows 8.1 and 2012 R2. The docs say it's 2, but tests, code, and other resources indicate it's 3.

Please double check if it's correct, and let me know if I should modify this PR.

@jandubois
Copy link
Member

Thank you for your PR. You are correct, but it is slightly more complicated; the version returned depends on the version support declared in the manifest: https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1

Support for Windows 8.1 (and 10) has been declared in Perl/perl5@9964c51. Could you do some digging to determine which Perl versions have the updated manifest, and then add a footnote that explains that Windows 8.1 and 10 will return version 6.2 on earlier Perl releases? Something like https://docs.microsoft.com/en-us/windows/win32/sysinfo/operating-system-version

Thank you!

@jandubois
Copy link
Member

which Perl versions have the updated manifest

I did a quick check, and it looks like this change is in v5.24.0 and later, but please verify! (Well, v5.23.3, but the docs probably should not care about beta versions).

@ferki
Copy link
Author

ferki commented Jun 19, 2020

You are correct, but it is slightly more complicated; the version returned depends on the version support declared in the manifest: https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1

Interesting detail, thanks for pointing me to the right docs, I learned something new!

I did a quick check, and it looks like this change is in v5.24.0 and later, but please verify! (Well, v5.23.3, but the docs probably should not care about beta versions).

That's my own results too. I'll update this PR with the extra pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants