Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it support non-English language (like Chinese) #18

Merged
merged 1 commit into from
Jun 26, 2013

Conversation

terryyin
Copy link
Contributor

The "Get Json Value" api now will dump the Json part into a string. For English it's still no too inconvenient to check the value (just add the quote). But Chinese will be transformed into something like "\u8fcd". So make the dumps not ensure ascii.

@peritus
Copy link
Owner

peritus commented Jun 26, 2013

Looks about right.

peritus added a commit that referenced this pull request Jun 26, 2013
Make it support non-English language (like Chinese)
@peritus peritus merged commit 07278d8 into peritus:master Jun 26, 2013
@peritus
Copy link
Owner

peritus commented Jun 26, 2013

@terryyin Thank you.

There are more occurrences of json.dumps (for logging, etc.) — do you mind chinese-proofing those as well ?

@terryyin
Copy link
Contributor Author

Oh, sure.

On 2013-6-26, at 下午6:22, Filip Noetzel [email protected] wrote:

@terryyin Thank you.

There are more occurrences of json.dumps (for logging, etc.) — do you mind chinese-proofing those as well ?


Reply to this email directly or view it on GitHub.

@jinlxz
Copy link

jinlxz commented Nov 27, 2014

I have found the POST and Get keyworks doesn't support chinese, it will fail if the body contains chinese chars, and how can I work around or fix this issue, can you give me some suggestion?

@terryyin
Copy link
Contributor Author

terryyin commented Dec 1, 2014

Have you tried if it works for Python3? If yes, it's a encoding problem.

@jinlxz
Copy link

jinlxz commented Dec 2, 2014

no, i am running python 2.7.2, haven't gotten a plan to upgrade python. Truely it is a encoding problem, the error message is "UnicodeDecodeError: 'ascii' codec can't decode byte ..." when the POST keyword was invoked. and I found the request body contained some non-ascii chars, I think it is a encoding problem but i am not familar with python, shall I need to modify the source code or some tricks can work around it, can you give me some more adivces? it will be very appreciate, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants