You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Record single metric sample value zero when dont_delete=True.
Default behavior is to consider the single sample metric value
zero as non-existing (dont_delete=False).
This should not be a problem for throughput metric class but it
might incorrectly generate post-processing metric files for other
classes like 'count' type, e.g. latency.
Can we replicate some of the comments from the Perl version here for better understanding/documentation?
Which comment are your referring to?
The comments from the part I am changing are identical:
Perl version: https://github.com/perftool-incubator/toolbox/blob/main/perl/toolbox/metrics.pm#L106-L107
# This metric has only 1 sample and the value is 0, so it "did not do any work". Therefore, we can just
# not create this metric at all.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rafaelfolco
force-pushed
the
metric-zero
branch
from
This results in incorrectly generated post-processing metric files. Only skip it as non-existent for throughput class.