Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the handling of no json schema provided to functions in the pe… #75

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

k-rister
Copy link
Contributor

…rl json module

  • the validate_schema function returns 0 when no schema is provided, so the expectation of a non-zero return code by get_json_file and put_json_file when no valid schema was provided was wrong

@k-rister k-rister added the bug Something isn't working label Jan 19, 2024
@k-rister k-rister requested a review from atheurer January 19, 2024 19:45
@k-rister k-rister self-assigned this Jan 19, 2024
…rl json module

- the validate_schema function returns 0 when no schema is provided,
  so the expectation of a non-zero return code by get_json_file and
  put_json_file when no valid schema was provided was wrong
@k-rister k-rister merged commit f23f81a into main Jan 19, 2024
136 checks passed
@k-rister k-rister deleted the dev-kmr branch January 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants