Skip to content

Commit

Permalink
Merge pull request #89 from perftool-incubator/bugfix
Browse files Browse the repository at this point in the history
Bugfix
  • Loading branch information
rafaelfolco authored Nov 21, 2024
2 parents 83a7f68 + 0e61104 commit 48f42ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/toolbox/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def finish_samples(dont_delete=False):
for idx in range(0, len(stored_sample)):
if file_id in metric_data_fh.keys():
if (stored_sample[idx]['value'] == 0 and idx not in num_written_samples.keys() and
and dont_delete is False):
dont_delete is False):
# This metric has only 1 sample and the value is 0, so it "did not do any work". Therefore, we can just
# not create this metric at all.
# TODO: This optimization might be better if the metric source/type could opt in/out of this.
Expand Down

0 comments on commit 48f42ca

Please sign in to comment.