remotehosts.py endpoint #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just created for tracking purposes at this point. |
|
This PR depends on perftool-incubator/crucible#340 being merged and a new controller image being created which includes it. |
|
Another PR that this PR is dependent on: perftool-incubator/toolbox#76 |
k-rister
force-pushed
the
dev-kmr
branch
2 times, most recently
from
611a3be to
408e39f
Compare
k-rister
force-pushed
the
dev-kmr
branch
2 times, most recently
from
3129b7c to
8892b84
Compare
|
I have a crucible-ci commit that is pending submission as a PR once this PR is complete that will add testing for this new endpoint: |
…ore useful with the endpoint label to pinpoint exactly which endpoint is breaking
…or use by crucible-ci
k-rister
force-pushed
the
dev-kmr
branch
2 times, most recently
from
357f07d to
93504b3
Compare
rafaelfolco
reviewed
Apr 29, 2024
rafaelfolco
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a from scratch implementation of a new endpoint called remotehosts. This endpoint has many new/different design points that are meant to address existing scalability issues with the remotehost endpoint while also implementing our new endpoint paradigm -- namely that they be written in Python and they use the run-file JSON interface to load their configuration information instead of the CLI stream that existing endpoints use.