Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kmr #139

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Dev kmr #139

merged 4 commits into from
Aug 23, 2024

Conversation

k-rister
Copy link
Contributor

resolve some issues where a new controller build was not being properly tested

  • make sure that the ci tests it's own ability to build images
  • when a new controller build is being tested force it to build new images rather than used cached ones to ensure that the build process works with the new controller

@k-rister k-rister added the bug Something isn't working label Aug 22, 2024
@k-rister k-rister requested a review from a team August 22, 2024 20:28
@k-rister k-rister self-assigned this Aug 22, 2024
atheurer
atheurer previously approved these changes Aug 22, 2024
…" if a CI built controller is used

- We need to ensure that the CI controller is fully tested by building
  images.

- Without this change it is possible that the CI controller will not
  have to build any images and then it won't be fully tested.  This
  can happen since it's possible for all the necessary images to
  already exist and recent changes such as expiration refresh make
  that more likely than ever.
@k-rister
Copy link
Contributor Author

Forcing this to merge without reviews or passing all of the checks in order to work around the bug this is meant to fix -- the CI now detects the bug that is present in the crucible repo and so it fails.

@k-rister k-rister merged commit 8d41d51 into main Aug 23, 2024
328 of 454 checks passed
@k-rister k-rister deleted the dev-kmr branch August 23, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants