Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev kmr #118

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Dev kmr #118

merged 4 commits into from
Jun 10, 2024

Conversation

k-rister
Copy link
Contributor

@k-rister k-rister commented Jun 8, 2024

No description provided.

k-rister added 2 commits June 8, 2024 14:00
…ngine registries

- the action will configure either a ci or production registry based
  on the discovered token

- if both are discovered then that results in an error
k-rister added 2 commits June 9, 2024 08:05
…n engine registry auth token

- the exiting registry_auth secret is replaced by ci_registry_auth
  both both should continue to work for backwards compatibility

- at some point in the future the registry_auth secret will be removed
  once all callers of the workflows have been updated
…_auth instead of registry_auth as the secret name
Copy link
Contributor

@rafaelfolco rafaelfolco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides the mix of purposes on the same pr (which imho is not ideal)

@k-rister k-rister merged commit 6bcf0f8 into main Jun 10, 2024
740 checks passed
@k-rister k-rister deleted the dev-kmr branch June 10, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants