Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpu main thread #39

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Cpu main thread #39

merged 1 commit into from
Dec 10, 2024

Conversation

rafaelfolco
Copy link
Contributor

No description provided.

@rafaelfolco rafaelfolco requested a review from k-rister October 24, 2024 14:52
k-rister
k-rister reviewed Oct 24, 2024
View reviewed changes
oslat-client Outdated Show resolved Hide resolved
@rafaelfolco rafaelfolco requested a review from k-rister October 28, 2024 17:56
k-rister
k-rister reviewed Oct 28, 2024
View reviewed changes
oslat-server-start Outdated Show resolved Hide resolved
oslat-client Outdated Show resolved Hide resolved
@rafaelfolco rafaelfolco marked this pull request as draft November 8, 2024 20:09
@rafaelfolco rafaelfolco marked this pull request as ready for review November 14, 2024 18:16
@rafaelfolco rafaelfolco requested a review from k-rister November 14, 2024 18:16
k-rister
k-rister requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@k-rister k-rister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems find except for some really weird indentation stuff -- mostly (only?) in the arg processing part. Can you fix that?

@rafaelfolco rafaelfolco force-pushed the cpu-main-thread branch 4 times, most recently from b89f68d to 10f6a7b Compare November 22, 2024 15:19
@rafaelfolco rafaelfolco requested a review from k-rister December 4, 2024 17:03
k-rister
k-rister previously approved these changes Dec 4, 2024
View reviewed changes
@rafaelfolco rafaelfolco marked this pull request as draft December 6, 2024 18:33
@rafaelfolco
Copy link
Contributor Author

rafaelfolco commented Dec 6, 2024 •
edited
Loading

I was able to reproduce the issue we're seeing in CI.
The 4th sample fails on client-start-end step (The first 3 samples worked just fine).
investigating...

1-4-1:client-start-end.txt.xz:[2024-12-05 19:36:06,956][CRITICAL] Roadblock failed with timeout 1-4-1:client-start-end.txt.xz:[2024-12-05 19:36:06,959][CRITICAL] These followers never reached 'online': server-1

@rafaelfolco
Add params: cpu-list and cpu-main-thread
6dcfe19 
Default is to use the housekeeping cpus for main thread, and
the workload cpus for cpu-list (measure latency).
@rafaelfolco rafaelfolco marked this pull request as ready for review December 10, 2024 11:42
@rafaelfolco rafaelfolco requested a review from k-rister December 10, 2024 11:42
k-rister
k-rister reviewed Dec 10, 2024
View reviewed changes
oslat-client Show resolved Hide resolved
@rafaelfolco rafaelfolco merged commit 5c7cc7a into master Dec 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-rister k-rister k-rister approved these changes

Assignees

@rafaelfolco rafaelfolco

Labels
None yet
Projects
Crucible Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelfolco @k-rister