fix memrchr detection #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this function is defined not on Linux but on GNU, that is, systems with glibc 2.2 or higher; also, use an intermediate HAVE_MEMRCHR symbol that people with alternative C libraries can define to indicate its presence
|
I think maybe you ought to send this upstream to https://github.com/google/compact_enc_det instead. |
|
Gregorio Litenstein dixit:
I think maybe you ought to send this upstream to
https://github.com/google/compact_enc_det
Hmm, good point, but not...
instead.
... but additionally, so you can fix it ahead
of time already. Thanks for the hint!
|
|
I guess we could merge it here and send it upstream from here. |
|
Submitted as google#16 Edit: Oh, I see you commented in the meanwhile… mh anyway, having it fixed in both won’t hurt. |
|
closing in favor of #3 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is defined not on Linux but on GNU, that is, systems with glibc 2.2 or higher; also, use an intermediate
HAVE_MEMRCHRsymbol that people with alternative C libraries can define to indicate its presence.This fix is necessary to allow building on GNU/Hurd and GNU/kFreeBSD, both of which have architectures present in Debian.