pmda-denki RAPL MSR support #2106
Open
+962
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, only /sys file system RAPL sources were supported. This adds /dev/msr register support, found on Intel. This makes on many Intel chips an exciting new metric available which reflects the overall systems power consumption - so far we have to use battery-metrics or smart meter for that.
Selinux looks good for the new MSR metrics.
I see just one unsolved issue with these commits: qa/1515 is right now failing. I do not see how to fix it, it seems the reason is that the new version of pmda-denki is outputting more defails to DEBUG-INFO. That's pieces output after initialization just one time and intended. Not sure how to modify the test accordingly.
Regarding man-page: it can be removed from the commit, no useful content was updated (but the tool changed all kinds of formatting).