Fix import in ternary statement #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninadbstack
approved these changes
Nov 15, 2024
ninadbstack
reviewed
Nov 15, 2024
ninadbstack
reviewed
Nov 19, 2024
Co-authored-by: ninadbstack <[email protected]>
prklm10
approved these changes
Nov 19, 2024
prklm10
added a commit
that referenced
this pull request
Jan 9, 2025
* PAC file support via PERCY_PAC_FILE_URL env var (#1784) * PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts * Fix import in ternary statement (#1779) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.0 * Cli bundling import fix (#1785) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.1 * v1.30.3-alpha.2 * Cli bundling import fix (#1794) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <[email protected]> --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.3 * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME (#1799) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there (#1800) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there * Bumped the percy tag to 1.30.3-alpha.5 * fixed linting * client-fix * upload-cli-fix * cli-build-fix * cli-exec-fix * cli-snapshot-fix * MERGE_COMMIT * MERGE_COMMIT * Proxy.test * proxy * core fixed * client package * client package * client package * client package * client package * lock file * pac-packages * pac-packages * pac-packages * lint pass * lint pass * lint pass * lint pass * proxy pass * client pass * api-test * api-test * percy-test-cases * Removed find revision * lint-fix --------- Co-authored-by: Khushhal Maheshwari <[email protected]> Co-authored-by: ninadbstack <[email protected]> Co-authored-by: Ninad Sheth <[email protected]> Co-authored-by: prklm10 <[email protected]> Co-authored-by: Mukul Bhutiani <[email protected]>
amandeepsingh333
pushed a commit
that referenced
this pull request
Jan 10, 2025
* PAC file support via PERCY_PAC_FILE_URL env var (#1784) * PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts * Fix import in ternary statement (#1779) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.0 * Cli bundling import fix (#1785) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.1 * v1.30.3-alpha.2 * Cli bundling import fix (#1794) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <[email protected]> --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.3 * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME (#1799) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there (#1800) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there * Bumped the percy tag to 1.30.3-alpha.5 * fixed linting * client-fix * upload-cli-fix * cli-build-fix * cli-exec-fix * cli-snapshot-fix * MERGE_COMMIT * MERGE_COMMIT * Proxy.test * proxy * core fixed * client package * client package * client package * client package * client package * lock file * pac-packages * pac-packages * pac-packages * lint pass * lint pass * lint pass * lint pass * proxy pass * client pass * api-test * api-test * percy-test-cases * Removed find revision * lint-fix --------- Co-authored-by: Khushhal Maheshwari <[email protected]> Co-authored-by: ninadbstack <[email protected]> Co-authored-by: Ninad Sheth <[email protected]> Co-authored-by: prklm10 <[email protected]> Co-authored-by: Mukul Bhutiani <[email protected]>
amandeepsingh333
pushed a commit
that referenced
this pull request
Jan 10, 2025
* PAC file support via PERCY_PAC_FILE_URL env var (#1784) * PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts * Fix import in ternary statement (#1779) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.0 * Cli bundling import fix (#1785) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.1 * v1.30.3-alpha.2 * Cli bundling import fix (#1794) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <[email protected]> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <[email protected]> --------- Co-authored-by: ninadbstack <[email protected]> * v1.30.3-alpha.3 * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME (#1799) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there (#1800) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there * Bumped the percy tag to 1.30.3-alpha.5 * fixed linting * client-fix * upload-cli-fix * cli-build-fix * cli-exec-fix * cli-snapshot-fix * MERGE_COMMIT * MERGE_COMMIT * Proxy.test * proxy * core fixed * client package * client package * client package * client package * client package * lock file * pac-packages * pac-packages * pac-packages * lint pass * lint pass * lint pass * lint pass * proxy pass * client pass * api-test * api-test * percy-test-cases * Removed find revision * lint-fix --------- Co-authored-by: Khushhal Maheshwari <[email protected]> Co-authored-by: ninadbstack <[email protected]> Co-authored-by: Ninad Sheth <[email protected]> Co-authored-by: prklm10 <[email protected]> Co-authored-by: Mukul Bhutiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will fix the bundling issue of Percy CLI lib when trying to bundle Percy inside LCNC Electron app