Fixing ignoreRegions for POA Full Page #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishigupta1599
requested review from
a team,
prklm10 and
ninadbstack
and removed request for
a team
ninadbstack
reviewed
Dec 15, 2023
Amit3200
reviewed
Dec 19, 2023
| } | ||
| } | ||
|
|
||
| async scrollToInitialPosition(x, y) { |
There was a problem hiding this comment.
lets have it as generic function then scrollToPosition(x,y) so if needed in future we can use it as we want and pass x and y accordingly?
ninadbstack
approved these changes
Dec 20, 2023
itsjwala
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Adding FullPage Support * Using tile based response * Fixing metadata * Fixing coverage * Adding coverage * Resolving comments * Resolving conflicts * Removing conflict * Resolving conflicts * Adding endl * Fixing tests * Fixing ignoreRegions for POA Full Page (#1466) * Fixing ignoreRegions for POA Full Page * Adding specs * Fixing coverage * Cleaning specs * Resolving comments * Resolving comments * Sending screenshotType to API (#1473) --------- Co-authored-by: rishigupta1599 <[email protected]> Co-authored-by: rishigupta1599 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring code to support ignoreRegions for Full Page Screenshot.
In full page screenshot Webpage can be at any scrolling state like (x,y), but the screenshot comes from the top (0,0), in that case proper scrolling factor need to be added in coordinates to get them wrt top of the DOM.