K8SPXC-1222: Remove state check for 5.7 #1915
reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (28)
build/pxc-entrypoint.sh|44 col 41| Double quote to prevent globbing and word splitting.
build/pxc-entrypoint.sh|63 col 5| ShellCheck can't follow non-constant source. Use a directive to specify location.
build/pxc-entrypoint.sh|251 col 5| Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
build/pxc-entrypoint.sh|261 col 5| Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
build/pxc-entrypoint.sh|262 col 24| Double quote to prevent globbing and word splitting.
build/pxc-entrypoint.sh|262 col 28| Double quote to prevent globbing and word splitting.
build/pxc-entrypoint.sh|303 col 48| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|316 col 34| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|316 col 70| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|372 col 8| Use -n instead of ! -z.
build/pxc-entrypoint.sh|380 col 8| Use -n instead of ! -z.
build/pxc-entrypoint.sh|380 col 32| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|437 col 8| Use -n instead of ! -z.
build/pxc-entrypoint.sh|451 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|469 col 8| Use -n instead of ! -z.
build/pxc-entrypoint.sh|486 col 7| Use -n instead of ! -z.
build/pxc-entrypoint.sh|492 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|507 col 21| Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
build/pxc-entrypoint.sh|513 col 112| Quote the right-hand side of != in [[ ]] to prevent glob matching.
build/pxc-entrypoint.sh|520 col 8| Use -n instead of ! -z.
build/pxc-entrypoint.sh|550 col 22| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|555 col 7| Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
build/pxc-entrypoint.sh|559 col 26| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|574 col 38| Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
build/pxc-entrypoint.sh|578 col 7| Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
build/pxc-entrypoint.sh|615 col 14| Double quote to prevent globbing and word splitting.
build/pxc-entrypoint.sh|668 col 51| Not following: /opt/percona/hookscript/hook.sh was not specified as input (see shellcheck -x).
build/pxc-entrypoint.sh|676 col 11| Double quote to prevent globbing and word splitting.
Filtered Findings (0)
Annotations
Check notice on line 44 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L44 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./build/pxc-entrypoint.sh:44:41: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check warning on line 63 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L63 <ShellCheck.SC1090>
ShellCheck can't follow non-constant source. Use a directive to specify location.
Raw output
./build/pxc-entrypoint.sh:63:5: warning: ShellCheck can't follow non-constant source. Use a directive to specify location. (ShellCheck.SC1090)
Check warning on line 251 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L251 <ShellCheck.SC2124>
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
Raw output
./build/pxc-entrypoint.sh:251:5: warning: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. (ShellCheck.SC2124)
Check warning on line 261 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L261 <ShellCheck.SC2124>
Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
Raw output
./build/pxc-entrypoint.sh:261:5: warning: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. (ShellCheck.SC2124)
Check notice on line 262 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L262 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./build/pxc-entrypoint.sh:262:24: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check notice on line 262 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L262 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./build/pxc-entrypoint.sh:262:28: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check warning on line 303 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L303 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:303:48: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check warning on line 316 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L316 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:316:34: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check warning on line 316 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L316 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:316:70: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 372 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L372 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:372:8: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check notice on line 380 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L380 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:380:8: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check warning on line 380 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L380 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:380:32: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 437 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L437 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:437:8: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check warning on line 451 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L451 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:451:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 469 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L469 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:469:8: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check notice on line 486 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L486 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:486:7: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check warning on line 492 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L492 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:492:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 507 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L507 <ShellCheck.SC2002>
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Raw output
./build/pxc-entrypoint.sh:507:21: info: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. (ShellCheck.SC2002)
Check warning on line 513 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L513 <ShellCheck.SC2053>
Quote the right-hand side of != in [[ ]] to prevent glob matching.
Raw output
./build/pxc-entrypoint.sh:513:112: warning: Quote the right-hand side of != in [[ ]] to prevent glob matching. (ShellCheck.SC2053)
Check notice on line 520 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L520 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./build/pxc-entrypoint.sh:520:8: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check warning on line 550 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L550 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:550:22: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 555 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L555 <ShellCheck.SC2002>
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Raw output
./build/pxc-entrypoint.sh:555:7: info: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. (ShellCheck.SC2002)
Check warning on line 559 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L559 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:559:26: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check warning on line 574 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L574 <ShellCheck.SC2166>
Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
Raw output
./build/pxc-entrypoint.sh:574:38: warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. (ShellCheck.SC2166)
Check notice on line 578 in build/pxc-entrypoint.sh
github-actions / shellcheck
[shellcheck] build/pxc-entrypoint.sh#L578 <ShellCheck.SC2002>
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
Raw output
./build/pxc-entrypoint.sh:578:7: info: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. (ShellCheck.SC2002)