PS-8927: Create table like doesn't write the charset on binlog if its… #5149

aybek · 2023-11-07T04:07:22Z

… created from a temporary table

https://jira.percona.com/browse/PS-8927

When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables.

This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

kamil-holubicki

LGTM.
Could you paste Jenkins link?

kamil-holubicki · 2023-12-04T14:34:13Z

mysql-test/suite/rpl/t/rpl_tmp_table_and_DDL.test

 # Cleanup
 --connection master
 DROP TEMPORARY TABLE temp_t1;
 DROP TABLE t1;
 --source include/rpl_end.inc
+


Empty line. Please remove.

aybek · 2023-12-05T04:11:16Z

Jenkins run: https://ps80.cd.percona.com/job/percona-server-8.0-pipeline-parallel-mtr/349/

percona-ysorokin · 2023-12-07T18:25:32Z

@aybek one more formatting issue with no new line at the end of file in mysql-test/suite/rpl/t/rpl_tmp_table_and_DDL.test.
Sorry
It's kinda good practice to always run git diff --check and git clang-format before the git commit to avoid such issues.
Please merge as soon as this is fixed.
When we merge directly into the release-xxx branch it's usually better to do this via Squash and Merge instead of Merge pull request.

percona-ysorokin

LGTM with minor formatting comment addressed

… created from a temporary table https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

…charset on binlog if its created from a temporary table) (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

…charset on binlog if its created from a temporary table) (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

…charset on binlog if its created from a temporary table) (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

…charset on binlog if its created from a temporary table) (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

…charset on binlog if its created from a temporary table) (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

… created from a temporary table (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

… created from a temporary table (#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica.

…charset on binlog if its created from a temporary table) (percona#5149) https://jira.percona.com/browse/PS-8927 When creating a table with CREATE TABLE ... LIKE ... from a temporary table, the create table isn't written entirely on the binary log, causing an error on the replica, which will create the table with the charset from the default database. Doesn't happen with persistent tables. This patch solves the problem by forcing the CHARSET to be present into CREATE TABLE statement of the binary log, as the reference table is temporary and may not exist on replica. (cherry picked from commit 3ae4402)

aybek requested a review from kamil-holubicki November 7, 2023 04:07

aybek self-assigned this Nov 7, 2023

aybek force-pushed the ps-8927 branch 2 times, most recently from 46a4175 to 5c7811f Compare November 7, 2023 05:52

aybek marked this pull request as ready for review November 7, 2023 09:31

inikep force-pushed the release-8.0.35-27 branch from 2d4e004 to 8515e86 Compare November 23, 2023 12:57

kamil-holubicki reviewed Dec 4, 2023

View reviewed changes

aybek force-pushed the ps-8927 branch from 5c7811f to 51f5826 Compare December 5, 2023 04:05

kamil-holubicki approved these changes Dec 5, 2023

View reviewed changes

percona-ysorokin approved these changes Dec 7, 2023

View reviewed changes

aybek force-pushed the ps-8927 branch from 51f5826 to 21eba92 Compare December 11, 2023 08:29

aybek merged commit 3ae4402 into percona:release-8.0.35-27 Dec 11, 2023
24 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PS-8927: Create table like doesn't write the charset on binlog if its… #5149

PS-8927: Create table like doesn't write the charset on binlog if its… #5149

aybek commented Nov 7, 2023

kamil-holubicki left a comment

kamil-holubicki Dec 4, 2023

aybek commented Dec 5, 2023

percona-ysorokin commented Dec 7, 2023

percona-ysorokin left a comment

PS-8927: Create table like doesn't write the charset on binlog if its… #5149

PS-8927: Create table like doesn't write the charset on binlog if its… #5149

Conversation

aybek commented Nov 7, 2023

kamil-holubicki left a comment

Choose a reason for hiding this comment

kamil-holubicki Dec 4, 2023

Choose a reason for hiding this comment

aybek commented Dec 5, 2023

percona-ysorokin commented Dec 7, 2023

percona-ysorokin left a comment

Choose a reason for hiding this comment