PS-7657 crash seen with update query on a partition table having comp… #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya-bodapati
requested changes
May 3, 2021
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
from
d81683f to
5dd253a
Compare
satya-bodapati
requested changes
May 4, 2021
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
from
5dd253a to
d555618
Compare
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
2 times, most recently
from
82d93e1 to
7f596d8
Compare
satya-bodapati
requested changes
May 7, 2021
mysql-test/suite/rpl/t/rpl_update_partitioned_table_with_compressed_column.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_update_partitioned_table_with_compressed_column.test
Outdated
Show resolved
Hide resolved
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
from
7f596d8 to
cb62982
Compare
venkatesh-prasad-v
requested changes
May 7, 2021
mysql-test/suite/rpl/t/rpl_update_partitioned_table_with_compressed_column.test
Outdated
Show resolved
Hide resolved
mysql-test/suite/rpl/t/rpl_update_partitioned_table_with_compressed_column.test
Outdated
Show resolved
Hide resolved
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
from
cb62982 to
925e59e
Compare
satya-bodapati
requested changes
May 10, 2021
…ressed column https://jira.percona.com/browse/PS-7657 Analysis : Update statements execution flow on tables with partitions by key and having compressed column: 1.First it searches for the row and positions the cursor (the blob is decompressed and stored in blob_heap and record is returned to server) 2. Builds new row and then calls update(old_row, new_row). Since the blob field doesn't change, the blob from old row is stored in the new row (mysql record) 3. Parition hanlder detects that the updated row should be in different partition 4. Insert the new row in new parition. During insertion, we empty the blob heap. This releases the blocks used by blob and corrupts the blob data in new row 5. So we end up inserting garbage to the new partition after the update Fix : Avoided prebuilt->compress_heap from being empty till it's required
nitendra-bhosle
force-pushed
the
5.7-PS-7657
branch
from
925e59e to
59cb3d5
Compare
venkatesh-prasad-v
approved these changes
May 11, 2021
There was a problem hiding this comment.
Thank you for addressing the review comments. The patch looks good and is approved from my side. But please wait for @satya-bodapati for the final approval.
satya-bodapati
requested changes
May 11, 2021
satya-bodapati
approved these changes
May 11, 2021
satya-bodapati
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ressed column
PS-7657 crash seen with update query on a partition table having compressed column