PS-4727 - intrinsic temp table behaviour shouldn't depend on innodb_e… #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1896/ is finished. Only unrelated tests(tokudb & rocksdb) tests failing |
laurynas-biveinis
approved these changes
Aug 13, 2018
| SET big_tables=ON; | ||
| INSERT INTO t1 SELECT * FROM t1; | ||
| DROP TABLE t1; | ||
| SET big_tables=default; |
There was a problem hiding this comment.
Instead of manipulating big_tables, a shorter version would be SELECT SQL_BIG_RESULT ...
There was a problem hiding this comment.
From documentation, "SQL_BIG_RESULT or SQL_SMALL_RESULT can be used with GROUP BY or DISTINCT to tell the optimizer that the result set has many rows or is small, respectively.'
Since I am using INSERT SELECT (although it may work), I would prefer SET big_tables here.
BTW, this is added as safety measure. With BLOBs, innodb storage engine is used in 5.7. In future (with temptable engine in 8.0 etc), this may not be true. So I added this protection
…ncrypt_tables Problem: -------- Optimizer temporary tables (aka Intrinsic temp table) encryption attribute is based on innodb_encrypt_tables. So when innodb_encrypt_tables is ON and innodb_temp_tablespace_encrypt is OFF, queries that use disk temp storage engine will fail. For example statements that use GROUP BY, ORDER BY, INSERT SELECT, etc will fail. Fix: ---- Intrinsic temp tables should derive encryption attribute from temporary tablespace property and not rely on innodb_encrypt_tables
satya-bodapati
force-pushed
the
PS-5.7-4727
branch
from
16ab495 to
df3b5ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncrypt_tables
Problem:
Optimizer temporary tables (aka Intrinsic temp table) encryption attribute is based on innodb_encrypt_tables. So when innodb_encrypt_tables is ON and innodb_temp_tablespace_encrypt is OFF, queries that use disk temp storage engine will fail. For example statements that use GROUP BY, ORDER BY INSERT SELECT, etc will fail.
Fix:
Intrinsic temp tables should derive encryption attribute from
temporary tablespace property and not rely on innodb_encrypt_tables