Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-10072 Filter out profiler collection #589

Closed
wants to merge 7 commits into from
Closed

PMM-10072 Filter out profiler collection #589

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
932ac45
PMM-10072 Filter out profiler collection
ShashankSinha252 Nov 7, 2022
1002fa3
Update system collection filter logic
ShashankSinha252 Dec 7, 2022
d5634f9
Enable test for system collection filtering
ShashankSinha252 Dec 7, 2022
742f1b9
Fix linter issues
ShashankSinha252 Dec 7, 2022
86e40cd
Merge branch 'main' into PMM-10072-reduce-permissions-requirements
ShashankSinha252 Dec 7, 2022
719dd5b
Merge branch 'main' into PMM-10072-reduce-permissions-requirements
BupycHuk Oct 8, 2023
cdf054e
Merge branch 'main' into PMM-10072-reduce-permissions-requirements
BupycHuk Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions exporter/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ import (
"go.mongodb.org/mongo-driver/mongo/options"
)

var systemDBs = []string{"admin", "config", "local"} //nolint:gochecknoglobals
var (
systemDBs = []string{"admin", "config", "local"} //nolint:gochecknoglobals
systemCollections = []string{"system.profile"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
systemCollections is a global variable (gochecknoglobals)

)

func listCollections(ctx context.Context, client *mongo.Client, database string, filterInNamespaces []string) ([]string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add tests for the new behavior of filtering collections?

filter := bson.D{} // Default=empty -> list all collections
Expand Down Expand Up @@ -63,7 +66,15 @@ func listCollections(ctx context.Context, client *mongo.Client, database string,
return nil, errors.Wrap(err, "cannot get the list of collections for discovery")
}

return collections, nil
filteredCollections := []string{}
for _, collection := range collections {
if collection == systemCollections[0] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is only one element in the systemCollections slice, could we use it as a constant variable?

Or if you plan to add more elements to systemCollections slice later could you please write this code which will work if the slice has two or more elements, but not only one?

continue
}
filteredCollections = append(filteredCollections, collection)
}

return filteredCollections, nil
ShashankSinha252 marked this conversation as resolved.
Show resolved Hide resolved
}

// databases returns the list of databases matching the filters.
Expand Down