Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1280 | Moving Storage class from first step to Advanced Configurations step #1171

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Tikdev00
Copy link
Collaborator

@Tikdev00 Tikdev00 commented Mar 6, 2025

EVEREST-1280 Powered by Pull Request Badge

Screenshot from 2025-03-06 19-41-17

@Tikdev00 Tikdev00 requested a review from a team as a code owner March 6, 2025 14:38
@Tikdev00 Tikdev00 changed the title EVEREST-1280 | Moving Storage class from first step to Advanced Confi… EVEREST-1280 | Moving Storage class from first step to Advanced Configurations step Mar 6, 2025
@Tikdev00 Tikdev00 self-assigned this Mar 6, 2025
@dianabirs
Copy link
Contributor

I think the container needs padding: 0 in order to look like in figma
image

gapFromText = 48,
}) => {
return (
<Card variant="outlined" sx={{ marginBottom: 2, padding: 2 }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Card variant="outlined" sx={{ marginBottom: 2, padding: 2 }}>
<Card variant="outlined" sx={{ marginBottom: 2 }}>

@fabio-silva
Copy link
Collaborator

@Tikdev00 I think you mentioned changing the other fields to be consistent with this one, right? In terms of UI, with that new border around.
Do you think we can pull that off?

@Tikdev00
Copy link
Collaborator Author

Tikdev00 commented Mar 7, 2025

@Tikdev00 I think you mentioned changing the other fields to be consistent with this one, right? In terms of UI, with that new border around. Do you think we can pull that off?

@fabio-silva Yes I think we can do it with the help of advanced card component I've created, we can put other fields inside it, maybe it will need a little bit more configurations but overall it's doable, just as we discussed we have missing things like Affinity and as task was mainly about Storage Class I didn't touched other existing fields which as you can see are changed, if it will not harm the scope of this task, I can refactor them as well. I am about external access and DB engine parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants