-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVEREST-1280 | Moving Storage class from first step to Advanced Configurations step #1171
base: main
Are you sure you want to change the base?
Conversation
Tikdev00
commented
Mar 6, 2025
•
edited
Loading
edited
gapFromText = 48, | ||
}) => { | ||
return ( | ||
<Card variant="outlined" sx={{ marginBottom: 2, padding: 2 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Card variant="outlined" sx={{ marginBottom: 2, padding: 2 }}> | |
<Card variant="outlined" sx={{ marginBottom: 2 }}> |
@Tikdev00 I think you mentioned changing the other fields to be consistent with this one, right? In terms of UI, with that new border around. |
@fabio-silva Yes I think we can do it with the help of advanced card component I've created, we can put other fields inside it, maybe it will need a little bit more configurations but overall it's doable, just as we discussed we have missing things like Affinity and as task was mainly about Storage Class I didn't touched other existing fields which as you can see are changed, if it will not harm the scope of this task, I can refactor them as well. I am about external access and DB engine parameters |